Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger: Add some sync IDC URLs to the debugger #7515

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Debugger: Add some sync IDC URLs to the debugger #7515

merged 1 commit into from
Jul 25, 2017

Conversation

ebinnion
Copy link
Contributor

After merging #5852, it'd be handy to have some extra debug information around what URLs a site is using as well as if the site is currently in an IDC.

To test:

  • Checkout branch
  • Go to $site.com/wp-admin/admin.php?page=jetpack-debugger
  • Ensure options are there and there are no errors

@ebinnion ebinnion added General IDC [Package] Sync [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 24, 2017
@ebinnion ebinnion added this to the 5.2 milestone Jul 24, 2017
@ebinnion ebinnion self-assigned this Jul 24, 2017
@ebinnion ebinnion requested a review from a team as a code owner July 24, 2017 22:24
@ebinnion ebinnion force-pushed the update/debugger-add-raw-idc-urls branch from cad77e6 to afa99e4 Compare July 24, 2017 22:25
roccotripaldi
roccotripaldi approved these changes Jul 24, 2017
View reviewed changes
Copy link
Member

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Ship it.

@roccotripaldi roccotripaldi added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 24, 2017
@ebinnion ebinnion merged commit 7e2bc4e into master Jul 25, 2017
@ebinnion ebinnion deleted the update/debugger-add-raw-idc-urls branch July 25, 2017 00:25
@ebinnion ebinnion removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roccotripaldi roccotripaldi roccotripaldi approved these changes

@lezama lezama Awaiting requested review from lezama

Assignees

@ebinnion ebinnion

Labels
General IDC [Package] Sync
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ebinnion @roccotripaldi